[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] xm_internal.c: remove two ret=... dead stores



On Fri, Sep 04, 2009 at 05:23:04PM +0200, Jim Meyering wrote:
> Two more dead stores:
> 
> >From 92bf654b02e5c1eb3334fc13ef52f5b0679512ea Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Fri, 4 Sep 2009 17:22:19 +0200
> Subject: [PATCH] xm_internal.c: remove two ret=... dead stores
> 
> * src/xm_internal.c (xenXMDomainCreate): Remove dead stores.
> ---
>  src/xm_internal.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xm_internal.c b/src/xm_internal.c
> index e675672..e948fa0 100644
> --- a/src/xm_internal.c
> +++ b/src/xm_internal.c
> @@ -1851,10 +1851,10 @@ int xenXMDomainCreate(virDomainPtr domain) {
>          goto error;
>      domain->id = ret;
> 
> -    if ((ret = xend_wait_for_devices(domain->conn, domain->name)) < 0)
> +    if (xend_wait_for_devices(domain->conn, domain->name) < 0)
>          goto error;
> 
> -    if ((ret = xenDaemonDomainResume(domain)) < 0)
> +    if (xenDaemonDomainResume(domain) < 0)
>          goto error;
> 
>      xenUnifiedUnlock(priv);

  Yes, ACK :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]