[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] xend_internal.c: Remove two dead stores to "ret"



On Fri, Sep 04, 2009 at 07:14:32PM +0200, Jim Meyering wrote:
> 
> 
> >From 99610dd77b95914623bd78f2bcac5d15a6c87024 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Fri, 4 Sep 2009 19:14:09 +0200
> Subject: [PATCH] xend_internal.c: Remove two dead stores to "ret"
> 
> * src/xend_internal.c (xenDaemonCreateXML): Don't set "ret" after
> last use.
> ---
>  src/xend_internal.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xend_internal.c b/src/xend_internal.c
> index cf45cd6..2fa08f1 100644
> --- a/src/xend_internal.c
> +++ b/src/xend_internal.c
> @@ -4028,10 +4028,10 @@ xenDaemonCreateXML(virConnectPtr conn, const char *xmlDesc,
>      if (!(dom = virDomainLookupByName(conn, def->name)))
>          goto error;
> 
> -    if ((ret = xend_wait_for_devices(conn, def->name)) < 0)
> +    if (xend_wait_for_devices(conn, def->name) < 0)
>          goto error;
> 
> -    if ((ret = xenDaemonDomainResume(dom)) < 0)
> +    if (xenDaemonDomainResume(dom) < 0)
>          goto error;
> 
>      virDomainDefFree(def);
> --
> 1.6.4.2.409.g85dc3

  Sure, ACK !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]