[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Split up qemudGetOldMachines()



On Mon, Sep 07, 2009 at 02:44:11PM +0100, Mark McLoughlin wrote:
> We need to look at all the domain infos in guest capabilities, not
> just the defaults.
> 
> In order to allow that, split out a qemudGetOldMachinesFromInfo()
> from qemudGetOldMachines(). We'll make more use of it in the next
> patch.
> 
> * src/qemu_conf.c: split out qemudGetOldMachinesFromInfo() from
>   qemudGetOldMachines()
[...]
> +    /* It sucks to have to dup these, when we're most likely going

 Hum, maybe we could clean this comment a bit while we refactor it,
I'm french but still :-)

  ACK to splitting out that chunk as a separated function,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]