[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]: Fixed minor bugs in display and added OOM checks.



> > Lastly added OOM checks in few places which were missed earlier.
>
>   Okay applied thanks !
> I would concur with Chris, I think the current practice in most
> of libvirt code when there is a complex routine is to handle
> OOM with a goto to an error label.

Thanks Chris and Daniel for the review, i will change the function here as 
well as others where there are complex routines and make it like the other 
drivers in libvirt, will soon post a patch for same.

> This allows to limit the level
> of cascading. This is stylistic, but affects readability, and
> hence maintainability :-)

stylistic, ha ha.

Thanks and Regards,
Pritesh


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]