[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/10] Simplify and fix qemudCanonicalizeMachine()



On Thu, 2009-09-10 at 14:13 +0200, Daniel Veillard wrote:
> On Thu, Sep 10, 2009 at 12:35:17PM +0100, Mark McLoughlin wrote:
> > The algorithm is quite simple:
> > 
> >   If the emulator matches a guest's domain:
> >     if domain has machine type info:
> >       check the domain's machine type info
> >     else
> >       check the guest's default machine type info
> >   else if the emulator matches the guest's default emulator:
> >      check the guest's default machine type info
> > 
> > The previous implementation was incorrectly falling back to the default
> > machine type info if the domain's machine type info didn't have an
> > alias.
> > 
> > * src/qemu_driver.c: simplify and fix qemudCanonicalizeMachine()
> > ---
> >  src/qemu_driver.c |   33 +++++++++++++++------------------
> >  1 files changed, 15 insertions(+), 18 deletions(-)
> 
>   That looks simpler, I'm a bit worried about landing this so close to
> 0.7.1 release though, but I guess we have good reasons,

Yeah - it's basically a blocker for people like Anton who's installed
kvm is newer than the installed qemu.

Pushing now

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]