[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/10] Consolidate "cont" into qemudMonitorSendCont()



On Mon, Sep 07, 2009 at 04:12:43PM +0200, Miloslav Trma?? wrote:
> The interface allows qemudMonitorSendCont() to report errors that are
> not overridden by its callers.
> 
> Also fix a potential infinite loop in qemuDomainCoreDump() if sending
> cont repeatedly fails.
> 
> Changes since the fourth submission:
> - Replace the "error_reported" parameter by using virGetLastError() in
>   callers
> 
> * src/qemu_driver.c (qemudMonitorSendCont): New function.
>   (qemudAutostartConfigs): Reset error before each call to
>   qemudStartVMDaemon().
>   (qemudInitCpus, qemudDomainResume, qemudDomainCoreDump,
>   qemudDomainRestore, qemudDomainMigratePerform,
>   qemudDomainMigrateFinish2): Use qemudMonitorSendCont().
> ---
>  src/qemu_driver.c |   79 +++++++++++++++++++++++++++-------------------------
>  1 files changed, 41 insertions(+), 38 deletions(-)

ACK, pushed this change

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]