[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Fix UUID handling in secrets/storage encryption APIs



On Fri, Sep 11, 2009 at 08:28:59PM -0400, Miloslav Trmac wrote:
> 
> ----- "Daniel P. Berrange" <berrange redhat com> wrote:
> > @@ -635,49 +620,25 @@ secretLookupByUUIDString(virConnectPtr conn,
> > const char *uuid)
> >  
> >      pptr = secretFind(driver, uuid);
> >      if (pptr == NULL) {
> > +        char uuidstr[VIR_UUID_STRING_BUFLEN];
> > +        virUUIDFormat(uuid, uuidstr);
> >          virSecretReportError(conn, VIR_ERR_NO_SECRET,
> > -                             _("no secret with matching id '%s'"), uuid);
> > +                             _("no secret with matching uuid '%s'"), uuidstr);
> >          goto cleanup;
> >      }
> >  
> > -    ret = virGetSecret(conn, (*pptr)->def->id);
> > +    ret = virGetSecret(conn, (*pptr)->def->uuid);
> >  
> >  cleanup:
> > +    if (1) {
> > +        char uuidstr[VIR_UUID_STRING_BUFLEN];
> > +        virUUIDFormat(uuid, uuidstr);
> > +        VIR_ERROR("Lookup %s got %p", uuidstr, ret);
> > +    }
> This looks like a debug print that should be removed in the final version.

Opps, yes that's killed now


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]