[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/11] Generic data stream handling



Daniel P. Berrange wrote:
> On Tue, Sep 15, 2009 at 02:35:02PM +0200, Chris Lalancette wrote:
>> I've uploaded the code that I'm trying out at the moment to:
>>
>> http://gitorious.org/~clalance/libvirt/clalance-staging/commits/tunnelled-migration
>>
>> Dan, can you take a look and make any suggestions about where I might be going
>> wrong?  
> 
> I've not look at your migration code yet, but there's a mistake in your
> change to the test driver.
> 
> http://gitorious.org/~clalance/libvirt/clalance-staging/commit/e77dc1f1ba4e18b4fc6a70198c2f3b253609dc42
> 
> The test driver is delibrately not using saferead/write because those
> helpers do not handle  EAGAIN. If you get EGAIN they'll return -1 and
> you are left with no idea how much data you've written which is not
> helpful :-) At very least this will cause the stream to terminate with
> an error message. If I got something wrong, perhaps its causing a crash.

Ah, I see.  I've switched that back, and switched over my tunnelled
implementation as well, but it doesn't seem to have an effect on my problem.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]