[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Fix Xen virConnectPtr leak



On Sat, Sep 19, 2009 at 11:50:21AM +0200, Matthias Bolte wrote:
> The commit cb51aa48a777ddae6997faa9f28350cb62655ffd "Fix up connection
> reference counting." changed the driver closing and virConnectPtr
> unref-logic in virConnectClose().
> 
> Before this commit virConnectClose() closed all drivers of the given
> virConnectPtr and virUnrefConnect()'ed it afterwards. After this
> commit the driver-closing is done in virUnrefConnect() if and only if
> the ref-count of the virConnectPtr dropped to zero.

[snip]

> The fix for this problem is simple: remove the
> virConnectRef/virUnrefConnect calls from the Xen subdrivers (see
> attached patch). Maybe someone could explain why the Xen Inotify and
> Xen Store driver do this extra ref-counting, but none of the other Xen
> subdrivers. It seems unnecessary to me and can be removed without
> problems.

Yes, this ref counting stuff in Xen internal drivers is totally bogus
and can be safely removed. ACk to your patch


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]