[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] python: Add a newline between virConnect and virNode for readability.



On Wed, Sep 23, 2009 at 01:01:25PM -0400, Cole Robinson wrote:
> In the generated bindings, they are squashed on top of each other.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  python/virConnect.py |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/python/virConnect.py b/python/virConnect.py
> index 1fdf548..096a1ba 100644
> --- a/python/virConnect.py
> +++ b/python/virConnect.py
> @@ -41,3 +41,4 @@
>              return 0
>          except AttributeError:
>              pass
> +

That's probably going to cause make syntax check to complain about a
trailing newline. You might be better making the generator insert
the newline instead.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]