[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] python: Add a newline between virConnect and virNode for readability.



On 09/23/2009 01:09 PM, Daniel P. Berrange wrote:
> On Wed, Sep 23, 2009 at 01:01:25PM -0400, Cole Robinson wrote:
>> In the generated bindings, they are squashed on top of each other.
>>
>> Signed-off-by: Cole Robinson <crobinso redhat com>
>> ---
>>  python/virConnect.py |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/python/virConnect.py b/python/virConnect.py
>> index 1fdf548..096a1ba 100644
>> --- a/python/virConnect.py
>> +++ b/python/virConnect.py
>> @@ -41,3 +41,4 @@
>>              return 0
>>          except AttributeError:
>>              pass
>> +
> 
> That's probably going to cause make syntax check to complain about a
> trailing newline. You might be better making the generator insert
> the newline instead.
> 
> Daniel

Yes, good call, I didn't think to run syntax-check, and it does
complain. I'll work up another patch.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]