[libvirt] [PATCH 2/9] Extend <disk> element with controller information

Wolfgang Mauerer wolfgang.mauerer at siemens.com
Fri Sep 25 13:03:43 UTC 2009


Matthias Bolte wrote:
> 2009/9/24 Daniel P. Berrange <berrange at redhat.com>:
>> Outside the scope of your patches, I think it would be
>> worth adding a 'name' attribute to all devices in the
>> libvirt XML as a standardized unique identifier. We
>> already have to keep track of a 'name' internally for
>> NIC hotplug with QEMU, and with QEMU's qdev work we're
>> going to end up having to track a 'name' for pretty much
>> all devices. Thus we might as well expose it in the XML
>>
> 
> Would this device name be read-only, or would it be editable/writable
> by the user (e.g. through virsh edit)? If it should be read-only, I
> see no problem supporting device names in the ESX driver. But If it
> should be editable/writable it may be a problem to implement this for
> the ESX driver, as I'm currently not aware of any sensible way to
> store such an custom device name in a persistent manner on an ESX
> server.

I suppose having the name read-only suffices. At least I
don't see any particularly important use cases for a
writeable name, especially considering that the name can be
chosen arbitrarily at creation time. And there's still the possibility
to shut down the virtual machine, change names, and restart again
if new names are absolutely required.

Thanks, Wolfgang




More information about the libvir-list mailing list