[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/27] Refactor QEMU monitor command handling



On Thu, 2009-09-24 at 16:00 +0100, Daniel P. Berrange wrote:

> This patch series is soooooo large, because I did it in many
> small steps, one command at a time.

I wouldn't apologize for there being so many patches ... it makes it
easier to review.

In fact, I'd have gone further - there are a number of changes which go
beyond simple code re-factoring into real bugfix territory. I'd have
like to see those changes as separate patches, allowing them to be
reviewed carefully and then just glance over the re-factoring patches.

> It is also now much easier to debug the monitor by just setting
> the env variables
> 
> LIBVIRT_LOG_OUTPUTS="1:stderr" LIBVIRT_LOG_FILTERS="1:qemu_monitor"
> 
> And you'll get the command & reply of each monitor interaction
> printed

Nice

> I've tested basic handling of every new method with the exception
> of the migration ones, since I don't have a convenient target host
> when on my laptop.
> 
> Overall we get a small increase in code size, but huge increase
> in readability !

Yep, it's much nicer now

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]