[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 22/27] Add API for issuing 'pci_add nic' monitor command



On Thu, 2009-09-24 at 16:00 +0100, Daniel P. Berrange wrote:
> * src/qemu/qemu_conf.c: Remove separator from qemuBuildNicStr()
>   args, and remove hardcoded 'nic' prefix. Leave it upto callers
>   instead
> * src/qemu/qemu_driver.c: Switch over to using the new
>   qemuMonitorAddPCINetwork() method for NIC hotplug
> * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
>   qemuMonitorAddPCINetwork API for PCI network device hotplug
> ---
>  src/qemu/qemu_conf.c         |    6 +--
>  src/qemu/qemu_conf.h         |    1 -
>  src/qemu/qemu_driver.c       |   93 ++++--------------------------------------
>  src/qemu/qemu_monitor_text.c |   36 ++++++++++++++++
>  src/qemu/qemu_monitor_text.h |    9 ++++
>  5 files changed, 55 insertions(+), 90 deletions(-)
> 
...
> diff --git a/src/qemu/qemu_monitor_text.h b/src/qemu/qemu_monitor_text.h
> index b6dae52..1bd9d6d 100644
> --- a/src/qemu/qemu_monitor_text.h
> +++ b/src/qemu/qemu_monitor_text.h
> @@ -170,6 +170,15 @@ int qemuMonitorAddPCIDisk(const virDomainObjPtr vm,
>                            unsigned *guestBus,
>                            unsigned *guestSlot);
>  
> +/* XXX do we really want to hardcode 'nicstr' as the
> + * sendable item here
> + */
> +int qemuMonitorAddPCINetwork(const virDomainObjPtr vm,
> +                             const char *nicstr,
> +                             unsigned *guestDomain,
> +                             unsigned *guestBus,
> +                             unsigned *guestSlot);

Could split nicstr into vlan/macaddr

ACK

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]