[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 23/27] Add API for issuing 'host_net_add' monitor command



On Thu, 2009-09-24 at 16:00 +0100, Daniel P. Berrange wrote:
> * src/qemu/qemu_conf.h, src/qemu/qemu_conf.c: Remove prefix arg
>   from qemuBuildHostNetStr which is no longer required
> * src/qemu/qemu_driver.c: Refactor to use qemuMonitorAddHostNetwork()
>   API for adding host network
> * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
>   qemuMonitorAddHostNetwork() method for adding host networks
> ---
>  src/qemu/qemu_conf.c         |   14 ++++----------
>  src/qemu/qemu_conf.h         |    1 -
>  src/qemu/qemu_driver.c       |   16 ++++++----------
>  src/qemu/qemu_monitor_text.c |   30 ++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_text.h |    7 +++++++
>  5 files changed, 47 insertions(+), 21 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index c531454..1d98637 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -1287,7 +1287,6 @@ qemuBuildNicStr(virConnectPtr conn,
>  int
>  qemuBuildHostNetStr(virConnectPtr conn,
>                      virDomainNetDefPtr net,
> -                    const char *prefix,
>                      char type_sep,
>                      int vlan,
>                      const char *tapfd,

Funny that you removed the prefix arg in this patch, but the type_sep
arg in the previous patch. I see why, though

ACK

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]