[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] minor fix's



2009/9/30 Pritesh Kothari <Pritesh Kothari sun com>:
> Hi All,
>
> Just minor fix's.
>
> Regards,
> Pritesh
>

I came across this 64bit compile problem (with -Werror) as well, but I
would fix it differently: Change the signature of
remoteSendStreamData() to use unsigned int instead of size_t. This is
possible because remoteSendStreamData() is not part of the public API
and it's currently called with len set to 0 or with len set to an int
value returned by virStreamRecv().

Matthias
diff --git a/daemon/dispatch.c b/daemon/dispatch.c
index e9fe260..ae4f60d 100644
--- a/daemon/dispatch.c
+++ b/daemon/dispatch.c
@@ -589,7 +589,7 @@ int
 remoteSendStreamData(struct qemud_client *client,
                      struct qemud_client_stream *stream,
                      const char *data,
-                     size_t len)
+                     unsigned int len)
 {
     struct qemud_client_message *msg;
     XDR xdr;
diff --git a/daemon/dispatch.h b/daemon/dispatch.h
index a5bf474..ed9d89d 100644
--- a/daemon/dispatch.h
+++ b/daemon/dispatch.h
@@ -75,6 +75,6 @@ int
 remoteSendStreamData(struct qemud_client *client,
                      struct qemud_client_stream *stream,
                      const char *data,
-                     size_t len);
+                     unsigned int len);
 
 #endif /* __LIBVIRTD_DISPATCH_H__ */

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]