[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Various monitor cleanups related to migration.

On Wed, Sep 30, 2009 at 01:27:20PM +0200, Chris Lalancette wrote:
> The upcoming tunnelled migration needs to be able to set
> a migration in progress in the background, as well as
> be able to cancel a migration when a problem has happened.
> This patch allows for both of these to properly work.

NACK, these are internal methods intentionally not exported since their
usage is dependant on the text based monitor syntax.

You should add another qemuMonitorMigrateToUNIX()  API for doing UNIX
socket based migration which simply takes the socket path name,
and use the qemuMonitorMigrateToCommand() API for the back-compat
exec/nc  based impl.

Can easily add another boolean flag to these for putting migration
in the background too

|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]