[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 1/2] nwfilter: Fixes to instantiator and some more parser fixes



On Thu, Apr 01, 2010 at 03:16:23PM -0400, Stefan Berger wrote:
> The following issues are fixed in the patch below:
> 
> - ebtables requires that some of the command line parameters are passed as hex numbers; so have those attributes call a function that prints 16 and 8 bit integers as hex nunbers.
> 
> - ip6tables requires '--icmpv6-type' rather than '--icmp-type'
> 
> - ebtables complains about protocol identifiers lower than 0x600, so already discard anything lower than 0x600 in the parser
> 
> - make the protocol entry types more readable using a #define for its entries
> 
> - continue parsing a filtering rule even if a faulty entry is encountered; return an error value at the end and let the caller decide what to do with the rule's object
> 
> - fix an error message
> 
> Signed-off-by: Stefan Berger <stefanb us ibm com>

  ACK, looks fine,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]