[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [1/4] Add managed save API entry points



On 04/02/2010 01:53 PM, Daniel Veillard wrote:
> [unchanged in v2]
> 
> Add managed save API entry points
> 
> virDomainManagedSave() is to be run on a running domain. Once the call
> complete, as in virDomainSave() the domain is stopped upon completion,
> but there is no restore counterpart as any order to start the domain
> from the API would load the state from the managed file, similary if
> the domain is autostarted when libvirtd starts.

Grammar and spelling tweaks for the commit message.  This would read
better as:

virDomainManagedSave() is to be run on a running domain.  Once the call
completes, the domain is stopped (as in virDomainSave()).  There is no
restore counterpart, as the managed file will be automatically restored
on any request to start the domain from the API, or if the domain is
autostarted when libvirtd starts.

But nothing wrong with the commit itself, at least that I could see.  ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]