[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [2/4] Implement remote protocol for managed save



On 04/02/2010 01:54 PM, Daniel Veillard wrote:
> +static int
> +remoteDispatchDomainHasManagedSaveImage (struct qemud_server *server ATTRIBUTE_UNUSED,
> +                                         struct qemud_client *client ATTRIBUTE_UNUSED,
> +                                         virConnectPtr conn,
> +                                         remote_message_header *hdr ATTRIBUTE_UNUSED,
> +                                         remote_error *rerr,
> +                                         remote_domain_has_managed_save_image_args *args,
> +                                         void *ret ATTRIBUTE_UNUSED)
> +{
> +    virDomainPtr dom;
> +
> +    dom = get_nonnull_domain (conn, args->dom);
> +    if (dom == NULL) {
> +        remoteDispatchConnError(rerr, conn);
> +        return -1;
> +    }
> +
> +    if (virDomainHasManagedSaveImage (dom, args->flags) == -1) {
> +        virDomainFree(dom);
> +        remoteDispatchConnError(rerr, conn);
> +        return -1;
> +    }
> +    virDomainFree(dom);
> +    return 0;
> +}

Shouldn't this be able to return 1 in the case where
virDomainHasManagedSaveImage returns 1?

> +static int
> +remoteDomainHasManagedSaveImage (virDomainPtr domain, unsigned int flags)
> +{
> +    int rv = -1;
> +    remote_domain_has_managed_save_image_args args;
> +    struct private_data *priv = domain->conn->privateData;
> +
> +    remoteDriverLock(priv);
> +
> +    make_nonnull_domain (&args.dom, domain);
> +    args.flags = flags;
> +
> +    if (call (domain->conn, priv, 0, REMOTE_PROC_DOMAIN_HAS_MANAGED_SAVE_IMAGE,
> +              (xdrproc_t) xdr_remote_domain_has_managed_save_image_args, (char *) &args,
> +              (xdrproc_t) xdr_void, (char *) NULL) == -1)
> +        goto done;
> +
> +    rv = 0;
> +
> +done:
> +    remoteDriverUnlock(priv);
> +    return rv;
> +}

Likewise.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]