[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [3/4] Implement managed save operations for qemu driver



On Fri, Apr 02, 2010 at 03:27:53PM -0600, Eric Blake wrote:
> On 04/02/2010 03:19 PM, Daniel Veillard wrote:
> >>> +    managed_save = qemuDomainManagedSavePath(driver, vm);
> >>> +    if ((managed_save) && (virFileExists(managed_save))) {
> >>> +        /* We should still have a reference left to vm but */
> >>
> >> Incomplete comment?

  in retrospect, yes, unless you could read my mind :-)

> >   not really, that could be "but ..." or "but one should check for 0
> >   anyway"
> > 
> > I end up with the following additional patch,
> 
> > -        /* We should still have a reference left to vm but */
> > +        /*
> > +         * We should still have a reference left to vm but
> > +         * but one should check for 0 anyway
> > +         */
> 
> s/but but/but/

 Dohh right, fixed, thanks !

It's interesting how one perceive things differently in code and
comments between a cold out of context analysis, and a warm one
where a lot of mental assumptions have already be made around it.
And what makes this external review process so effective (an I guess
core part of the Extreme Programming method).

  So thanks a lot of your feedback :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]