[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 19/30] nwfilter: Remove virConnectPtr from virNWFilterReportError




Matthias,

 I have a patch that does the same. Most of the non-search-replace work I needed to do was in nwfilter_ebiptables_driver.c where several functions have the virConnectPtr as parameter passing it all the way through to the function that used to pass it to the error reporting function.  If you take out modification to that file from your patch, I could commit mine and it would save me a lot of work again.

The summary of changes to this file in my patch look like this:

 src/nwfilter/nwfilter_ebiptables_driver.c |  762 ++++++++++++-----------------

  Regards,
     Stefan


>
> libvir-list-bounces redhat com

>
> ---
>  src/conf/nwfilter_conf.c                  |  120 ++++++-------
>  src/conf/nwfilter_conf.h                  |   16 +-
>  src/conf/nwfilter_params.c                |    2 +-
>  src/nwfilter/nwfilter_driver.c            |   25 ++--
>  src/nwfilter/nwfilter_ebiptables_driver.c |  285 ++++++++++
> +------------------
>  src/nwfilter/nwfilter_gentech_driver.c    |   39 ++--
>  src/nwfilter/nwfilter_gentech_driver.h    |    3 +-
>  tests/nwfilterxml2xmltest.c               |    2 +-
>  8 files changed, 202 insertions(+), 290 deletions(-)
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]