[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [2/4] Implement remote protocol for managed save



On 04/04/2010 05:24 AM, Daniel Veillard wrote:
> In the cases I checked and looked for it seems the network call()
> return values is always 0 or -1, and looking at virDomainGetMaxVcpus()
> it does use
> 
> struct remote_domain_get_max_vcpus_ret {
>     int num;
> };
> 
>   same for virDomainNumDomains()
> 
> and I also see
> 
> struct remote_num_of_defined_domains_ret {
>     int num;
> };
> 
>  in the src/remote/remote_protocol.x right now,
> remoteNumOfDefinedDomains( does use  remote_num_of_defined_domains_ret ret;
> and remoteDispatchNumOfDefinedDomains() do use a
> remote_num_of_defined_domains_ret *ret argument, so I'm wondering if we
> are really looking at the same code.
> 
>   In the case we just return 0 for success and -1 in case of error, we
> clearly don't need the return structure, but all examples I checked for
> an full int reurn used a structure. So I assume the change is needed,
> or at least it's safe :-)

Sigh, never mind me.  I looked at the wrong code.  You are right :).

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]