[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] Snapshots for VBox



> > diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> > index dac386d..ede2798 100644
> > --- a/src/vbox/vbox_tmpl.c
> > +++ b/src/vbox/vbox_tmpl.c
> > @@ -5007,6 +5007,976 @@ static int vboxDomainDetachDeviceFlags(virDomainPtr dom, const char *xml,
> >      return vboxDomainDetachDevice(dom, xml);
> >  }
> [...]
> > +
> > +#if VBOX_API_VERSION == 2002
> > +    if (VIR_ALLOC(iid) < 0) {
> > +        virReportOOMError();
> > +        goto cleanup;
> > +    }
> > +#endif
> 
>   Hum, did that specific allocation really need to occur only on one of the
> released versions of VBox ? and not before (or we don't support anything
> older than 2002)

We don't support anything older than 2.2 (2002). The only supported VirtualBox
API versions are 2.2, 3.0 and 3.1.

>   Except that and the constant UTF16 / UTF8 conversions which makes code
>   harder to follow, that looks normal,

Heh, yeah, that is a mess. Actually, the whole VirtualBox driver would deserve
to be cleaned up/refactored...

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]