[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Document snapshot virsh commands in the man page.



On 04/05/2010 05:05 PM, Eric Blake wrote:
> On 04/05/2010 11:37 AM, Chris Lalancette wrote:
>> +=item B<snapshot-create> I<domain> I<xmlfile>
>> +
>> +Create a snapshot for domain I<domain> with the properties specified in
>> +I<xmlfile>.  The only properties settable for a domain snapshot are the
>> +<name> and <description>; the rest of the fields are ignored, and
>> +automatically filled in by libvirt.  If I<xmlfile> is completely ommitted,
> 
> s/ommitted/omitted/

/me blushes.  I should know better.

> 
>> +=item B<revert-to-snapshot> I<domain> I<snapshot>
>> +
>> +Revert the given domain to the snapshot specified by I<snapshot>.  Be aware
>> +that this is a destructive action; any changes in the domain since the
>> +snapshot is taken will be lost.  Also note that the state of the domain after
> 
> I think it reads better to use s/snapshot is taken/snapshot was taken/,
> since the snapshot was created in the past compared to the current state
> of the domain that we are discarding.

Yep, agreed.  I re-worded that a few times and didn't fix up all of my grammar.

> 
> ACK, with those nits addressed.

Thanks, I've pushed with those nits fixed.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]