[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Implement variable length structure allocator



On 04/06/2010 06:59 AM, Dave Allan wrote:
>> Then again, fixing the type for your new method would imply fixing the
>> typing of virAlloc and friends as well.

Daniel's arguments are convincing; it's okay to keep the ugly cast in
the implementation if it makes the header easier to use without having
to embed a cast in the #define.

> Is everybody ok with having this allocator, btw?

You have my ACK, but I'm only a (small) fraction of everybody.  But
since no one is using them yet, is it worth waiting until after 0.8.0 to
push?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]