[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix CPU comparison for x86 arch



On Wed, Apr 07, 2010 at 04:42:26PM +0200, Jiri Denemark wrote:
> When comparing a CPU to host CPU, the result would be
> VIR_CPU_COMPARE_SUPERSET (or even VIR_CPU_COMPARE_INCOMPATIBLE if strict
> match was required) even though the two CPUs were identical.
> ---
>  src/cpu/cpu_x86.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
> index 46a9fbb..205528d 100644
> --- a/src/cpu/cpu_x86.c
> +++ b/src/cpu/cpu_x86.c
> @@ -963,8 +963,8 @@ x86Compute(virCPUDefPtr host,
>      x86ModelSubtract(diff, cpu_disable);
>      x86ModelSubtract(diff, cpu_force);
>  
> -    for (i = 0; i < host_model->ncpuid; i++) {
> -        if (!x86cpuidMatch(host_model->cpuid + i, &cpuid_zero)) {
> +    for (i = 0; i < diff->ncpuid; i++) {
> +        if (!x86cpuidMatch(diff->cpuid + i, &cpuid_zero)) {
>              ret = VIR_CPU_COMPARE_SUPERSET;
>              break;
>          }

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]