[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: s/initialis/initializ/



On 04/07/2010 09:39 AM, Daniel Veillard wrote:
> On Wed, Apr 07, 2010 at 09:18:28AM -0600, Eric Blake wrote:
>> git grep found 12 of the former but 100 of the latter in src/.
>>
>> * src/remote/remote_driver.c (initialise_gnutls): Rename...
>> (initialize_gnutls): ...to this.
>> (doRemoteOpen): Adjust caller.
>> * src/xen/xen_driver.c (xenUnifiedOpen): Adjust output string.
>> * src/util/network.c: Adjust comments.
>> Suggested by Matthias Bolte.
>> ---
>>
>> Should be a pretty trivial conversion from British to American
>> English for a single word.  Is it worth adding a rule to cfg.mk
>> to have 'make syntax-check' diagnose future introductions of
>> 'initialis.*'?
> 
>   Hum, there French and British agree on the spelling, so I'm probably
> partly guilty of those 12 (network.c) , but is that a real problem ;-) ?
> I'm fine with the patch, adding to syntax-check is probably a bit
> pedantic, no ?

I won't worry about a syntax check at this point, then (but it does mean
that I may end up doing another patch like this down the road).  The
main intent was the change in xen_driver.c, since translators deserve
consistent strings in the .pot; I don't care as much about comments, and
the static function name isn't part of the public API, but they were
easy to change as long as I was doing the work.

For the record, my wife is British, and she already says I can't spell;
but it means that I'm a little more tuned in to the differences between
the two dialects than most.

> 
> ACK

Pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]