[libvirt] [PATCH] qemudDomainGetSecurityLabel: avoid dead store to "type"

Jim Meyering jim at meyering.net
Wed Apr 7 18:43:10 UTC 2010


And another:

>From 61f50761015a82906aec31e5a1cdeef0eaf2b0a1 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Wed, 7 Apr 2010 17:51:56 +0200
Subject: [PATCH] qemudDomainGetSecurityLabel: avoid dead store to "type"

* src/qemu/qemu_driver.c (qemudDomainGetSecurityLabel): Remove store
and declaration.
---
 src/qemu/qemu_driver.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1e60591..f5cf1f1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5564,7 +5564,6 @@ static int qemudDomainGetSecurityLabel(virDomainPtr dom, virSecurityLabelPtr sec
 {
     struct qemud_driver *driver = (struct qemud_driver *)dom->conn->privateData;
     virDomainObjPtr vm;
-    const char *type;
     int ret = -1;

     qemuDriverLock(driver);
@@ -5580,7 +5579,7 @@ static int qemudDomainGetSecurityLabel(virDomainPtr dom, virSecurityLabelPtr sec
         goto cleanup;
     }

-    if (!(type = virDomainVirtTypeToString(vm->def->virtType))) {
+    if (!virDomainVirtTypeToString(vm->def->virtType)) {
         qemuReportError(VIR_ERR_INTERNAL_ERROR,
                         _("unknown virt type in domain definition '%d'"),
                         vm->def->virtType);
--
1.7.1.rc0.212.gbd88f




More information about the libvir-list mailing list