[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Properly advertise cpuselection guest capability



> > -    if (qemudProbeCPUModels(binary, info->arch, &ncpus, NULL) == 0
> > +    if (caps->host.cpu
> > +        && qemudProbeCPUModels(binary, info->arch, &ncpus, NULL) == 0
> >          && ncpus > 0
> >          && !virCapabilitiesAddGuestFeature(guest, "cpuselection", 1, 0))
> >          goto error;
> 
>   We usually put && on end of line

OK, I fixed this,

> and I really prefer fully parenthesized tests expressions

didn't fix this (also because it's actually pretty rare in libvirt code),

> ACK

and pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]