[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilters: Test suite for checking created firewall entries



On Wed, Apr 07, 2010 at 02:53:28PM -0400, Stefan Berger wrote:
> This patch adds new test cases to the existing nwfilter test program and
> adds a test script that must be run while a VM is running. This test
> script verifies that input network filter XML creates expected
> user-defined tables and rules on ebtables, iptables & ip6tables layer
> and verifies their content against expected content. The idea is that
> these tools always return exactly the same output when displaying the
> content of a user-defined table so that the diff tool can be used for
> simple text comparison. All supported protocols have at least one test
> case. 
> This test program is not run automatically since it requires a running
> VM.

I think this test should really be part of the libvirt-TCK, since that
provides you the framework for running real VMs & interacting with the
host OS.

The tests in libvirt/tests should all be unit tests which don't interact
with the host system state

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]