[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Avoid searching for windres when not building for cygwin or mingw.



On Fri, Feb 12, 2010 at 01:29:22PM +0100, Diego Elio Pettenò wrote:
> Just checking for a windres tool might hit even on Linux systems when
> building for Linux (e.g.: when using Gentoo and having built binutils with
> multitarget support), and will then fail to link properly at the end of the
> build.
> 
> Check the host string before deciding whether to look for windres or not.
> ---
>  configure.ac |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 29c6396..e6122b9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1676,8 +1676,13 @@ AC_SUBST([CYGWIN_EXTRA_PYTHON_LIBADD])
>  AC_SUBST([MINGW_EXTRA_LDFLAGS])
>  
>  dnl Look for windres to build a Windows icon resource.
> -AC_CHECK_TOOL([WINDRES], [windres], [no])
> -AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != "no"])
> +case "$host" in
> +  *cygwin* | *mingw* )
> +    AC_CHECK_TOOL([WINDRES], [windres], [])
> +    ;;
> +esac
> +
> +AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != ""])

  An old patch that we forgot, it's a cleanup, I just updated
the Windows test to match teh one a few lines before, then applied,

  pushed, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]