[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] nwfilter: fix for directionality of ICMP traffic




Daniel Veillard <veillard redhat com> wrote on 04/08/2010 03:44:05 AM:


>
> Please respond to veillard

>
> On Wed, Apr 07, 2010 at 05:44:53PM -0400, Stefan Berger wrote:
> > Changes from V1 to V2 of this patch
> > - I had reversed the logic thinking that icmp type 0 is a echo
> > request,but it's reply -- needed to reverse the logic
> > - Found that ebtables takes the --ip-tos argument only as a hex number
> >
> > This patch enables the skipping of some of the ICMP traffic rules on the
> > iptables level under certain circumstances so that the following filter
> > properly enables unidirectional pings:
>
>   Ah I hadn't seen v2, okay
>   Okay, I see the change is in the initialization of maySkipICMP, fine,
>
> ACK,


Pushed. Thanks.

  Stefan

>
> Daniel
>
> --
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  
http://xmlsoft.org/
> daniel veillard com  | Rpmfind RPM search engine
http://rpmfind.net/
>
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]