[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Rename virsh "revert-to-snapshot" to "snapshot-revert"



On Mon, Apr 12, 2010 at 09:46:33AM -0400, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette <clalance redhat com>
> ---
>  tools/virsh.c   |   10 +++++-----
>  tools/virsh.pod |    4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/virsh.c b/tools/virsh.c
> index 8017beb..d5fe6c4 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -8514,22 +8514,22 @@ cleanup:
>  }
>  
>  /*
> - * "revert-to-snapshot" command
> + * "snapshot-revert" command
>   */
> -static const vshCmdInfo info_revert_to_snapshot[] = {
> +static const vshCmdInfo info_snapshot_revert[] = {
>      {"help", N_("Revert a domain to a snapshot")},
>      {"desc", N_("Revert domain to snapshot")},
>      {NULL, NULL}
>  };
>  
> -static const vshCmdOptDef opts_revert_to_snapshot[] = {
> +static const vshCmdOptDef opts_snapshot_revert[] = {
>      {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")},
>      {"snapshotname", VSH_OT_DATA, VSH_OFLAG_REQ, N_("snapshot name")},
>      {NULL, 0, 0, NULL}
>  };
>  
>  static int
> -cmdDomainRevertToSnapshot(vshControl *ctl, const vshCmd *cmd)
> +cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd)
>  {
>      virDomainPtr dom = NULL;
>      int ret = FALSE;
> @@ -8786,7 +8786,7 @@ static const vshCmdDef commands[] = {
>      {"snapshot-delete", cmdSnapshotDelete, opts_snapshot_delete, info_snapshot_delete},
>      {"snapshot-dumpxml", cmdSnapshotDumpXML, opts_snapshot_dumpxml, info_snapshot_dumpxml},
>      {"snapshot-list", cmdSnapshotList, opts_snapshot_list, info_snapshot_list},
> -    {"revert-to-snapshot", cmdDomainRevertToSnapshot, opts_revert_to_snapshot, info_revert_to_snapshot},
> +    {"snapshot-revert", cmdDomainSnapshotRevert, opts_snapshot_revert, info_snapshot_revert},
>  
>      {NULL, NULL, NULL, NULL}
>  };
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 46ba813..4af5603 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -819,12 +819,12 @@ List all of the available snapshots for the given domain.
>  
>  Output the snapshot XML for the domain's snapshot named I<snapshot>.
>  
> -=item B<revert-to-snapshot> I<domain> I<snapshot>
> +=item B<snapshot-revert> I<domain> I<snapshot>
>  
>  Revert the given domain to the snapshot specified by I<snapshot>.  Be aware
>  that this is a destructive action; any changes in the domain since the
>  snapshot was taken will be lost.  Also note that the state of the domain after
> -revert-to-snapshot is complete will be the state of the domain at the time
> +snapshot-revert is complete will be the state of the domain at the time
>  the original snapshot was taken.
>  
>  =item B<snapshot-delete> I<domain> I<snapshot> I<--children>

  ACK, we discussed it previously, should be fixed before the release,
please push, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]