[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: use virFindFileInPath for needed CLI tools



On Tue, Apr 13, 2010 at 12:40:17PM -0400, Stefan Berger wrote:
> I am getting rid of determining the path to necessary CLI tools at
> compile time. Instead, now the firewall driver has an initialization
> function that uses virFindFileInPath() to determine the path to
> necessary CLI tools and a shutdown function to free allocated memory.
> The rest of the patch mostly deals with availability of the CLI tools
> and to not call certain code blocks if a tool is not available and that
> strings now have to be built slightly differently.
> 
> Signed-off-by: Stefan Berger <stefanb us ibm com>
> 
> ---
>  configure.ac                              |   12 
>  src/conf/nwfilter_conf.h                  |   10 
>  src/nwfilter/nwfilter_driver.c            |    3 
>  src/nwfilter/nwfilter_ebiptables_driver.c |  454 +++++++++++++++++++-----------
>  src/nwfilter/nwfilter_gentech_driver.c    |   25 +
>  src/nwfilter/nwfilter_gentech_driver.h    |    2 
>  6 files changed, 337 insertions(+), 169 deletions(-)

 Okay, I think this is a cleaner approach and more in line with what we
do for other executable detection. I was a bit suprized to notice you look
for grep, bash and awk too :-) A lot of the changes are really systematic
replace, strings looks properly freed, so that looks fine to me really,

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]