[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fixup python binding for virDomainSnapshot APIs



On 04/14/2010 10:03 AM, Daniel P. Berrange wrote:
> The generator code was totally wrong for the virDomainSnapshot
> APIs, not generating the wrapper class, and giving methods the
> wrong names
> 
> * generator.py: Set metadata for virDomainSnapshot type & APIs
> * libvirt-override-api.xml, libvirt-override.c: Hand-code the
>   virDomainSnapshotListNames glue layer
> ---
>  python/generator.py             |   27 ++++++++++++++++++++++-
>  python/libvirt-override-api.xml |    6 +++++
>  python/libvirt-override.c       |   46 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 78 insertions(+), 1 deletions(-)

Thanks for fixing this.  I'm not super familiar with the python generator,
but it all looks reasonable to me.

ACK

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]