[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Update to latest gnulib to get strtok_r relaxed to LGPLv2+

On 04/14/2010 06:32 PM, Matthias Bolte wrote:
> strtok_r will be used in the ESX driver to replace scanf-based code.
> MinGW lacks strtok_r, so we need gnulib to provide it, but until now
> strtok_r was licensed LGPL3.
> ---
>  .gnulib |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/.gnulib b/.gnulib
> index 097c9ce..7c1b995 160000
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 097c9ce08a79899ff942b9b6ee811e613605499f
> +Subproject commit 7c1b995a7041ea366acafeb8632e1080f349f03f

ACK.  However, if it were me, I'd rebase your series, and do the update
to both .gnulib and boostrap.conf in a single patch (import strtok_r),
then your ESX patch that uses strtok_r is isolated to just the esx
subdir instead of touching the global files.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]