[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Remove code from JSON monitor for commands that won't be ported



On Thu, Apr 15, 2010 at 11:43:08AM +0100, Daniel P. Berrange wrote:
> The QEMU developers have stated that they will not be porting
> the commands 'pci_add', 'pci_del', 'usb_add', 'usb_del' to the
> JSON mode monitor, since they're obsoleted by 'device_add'
> and 'device_del'. libvirt has (untested) code that would have
> supported those commands in theory, but since we already use
> device_add/del where available, there's no need to keep the
> legacy stuff anymore.
> 
> The text mode monitor keeps support for all commands for sake
> of historical compatability.
> 
> * src/qemu/qemu_monitor_json.c: Remove 'pci_add', 'pci_del',
>   'usb_add', 'usb_del' commands
> ---
>  src/qemu/qemu_monitor_json.c |  324 ++++++------------------------------------
>  1 files changed, 47 insertions(+), 277 deletions(-)
> 
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 2904201..ec04d79 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -1476,272 +1476,72 @@ int qemuMonitorJSONMigrateCancel(qemuMonitorPtr mon)
>  }
>  
>  

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]