[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix device_del in JSON mode for QEMU



On Fri, Apr 16, 2010 at 11:53:06AM +0100, Daniel P. Berrange wrote:
> The 'device_del' command expects a parameter called 'id' but we
> were passing 'config'.
> 
> * src/qemu/qemu_monitor_json.c: Fix device_del command parameter
> ---
>  src/qemu/qemu_monitor_json.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 001b32b..c3ed47c 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -2021,7 +2021,7 @@ int qemuMonitorJSONDelDevice(qemuMonitorPtr mon,
>      virJSONValuePtr reply = NULL;
>  
>      cmd = qemuMonitorJSONMakeCommand("device_del",
> -                                     "s:config", devalias,
> +                                     "s:id", devalias,
>                                       NULL);
>      if (!cmd)
>          return -1;

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]