[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Add nwfilter driver stub



> > +static virDrvOpenStatus
> > +esxNWFilterOpen(virConnectPtr conn,
> > +                virConnectAuthPtr auth ATTRIBUTE_UNUSED,
> > +                int flags ATTRIBUTE_UNUSED)
> > +{
> 
> If Jirka's patch for virCheckFlags goes in first, you need to tweak this
> line.  Otherwise, his patch needs to touch this new file when it is rebased.

Hmm, this is not a public API, it's just internal function used when opening a
driver. I didn't change such functions in other places and I didn't do that
for this one either. If we decide we want to check internal APIs as well, we
can add the check for all of them at once.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]