[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] CPU selection fixes and tests



On 04/16/2010 11:01 AM, Jiri Denemark wrote:
> 4 out of the 8 tests added by patch 2/6 fail with current libvirt. After
> 5/6 some of them pass and some of them fail in a different way. After
> 6/6 all of them pass.

I would suggest that before pushing, you reorder the patches so that
'make check' passes for every stage of the patch series.  This makes
patch bisection easier in the future (if we are trying to hunt down a
regression, it's better if every commit builds independently).
Admittedly, it can look a bit odd seeing the commit that fixes the bug
before the commit that introduces the test, even though they were
developed in the opposite order, but you get used to it.  And 'git
rebase -i' makes it so easy to do.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]