[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/6] Tests for CPU selection in qemu driver



On 04/16/2010 11:01 AM, Jiri Denemark wrote:
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml
> @@ -0,0 +1,28 @@
> +<domain type='qemu'>
> +  <name>QEMUGuest1</name>
> +  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>

> +++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml
> @@ -0,0 +1,35 @@
> +<domain type='qemu'>
> +  <name>QEMUGuest1</name>
> +  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>

Is reusing the same UUID going to bite us later, especially when running
tests in parallel?

> +++ b/tests/qemuxml2argvtest.c
> @@ -346,6 +346,15 @@ mymain(int argc, char **argv)
>      DO_TEST_FULL("restore-v2", QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC, "exec:cat");
>      DO_TEST_FULL("migrate", QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP, "tcp:10.0.0.1:5000");
>  
> +    DO_TEST("cpu-topology1", QEMUD_CMD_FLAG_SMP_TOPOLOGY);
> +    DO_TEST("cpu-topology2", QEMUD_CMD_FLAG_SMP_TOPOLOGY);
> +    DO_TEST("cpu-topology3", 0);
> +    DO_TEST("cpu-minimum1", 0);
> +    DO_TEST("cpu-minimum2", 0);
> +    DO_TEST("cpu-exact1", 0);
> +    DO_TEST("cpu-exact2", 0);
> +    DO_TEST("cpu-strict1", 0);

I didn't spot anything blatantly unusual, although I'm not exactly sure
what I would be looking for.  Then again, I am assuming that since
everything passes when the entire series is applied, it certainly isn't
breaking anything to add new tests.  So,

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]