[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/30] Replace printf with logging macros



2010/4/5 Eric Blake <eblake redhat com>:
> On 04/04/2010 11:36 AM, Matthias Bolte wrote:
>> ---
>>  src/node_device/node_device_hal.c         |    2 +-
>>  src/nwfilter/nwfilter_ebiptables_driver.c |    6 +++---
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/node_device/node_device_hal.c b/src/node_device/node_device_hal.c
>> index 4bf445d..0174794 100644
>> --- a/src/node_device/node_device_hal.c
>> +++ b/src/node_device/node_device_hal.c
>> @@ -836,7 +836,7 @@ static int halDeviceMonitorReload(void)
>>      dbus_error_init(&err);
>>      udi = libhal_get_all_devices(hal_ctx, &num_devs, &err);
>>      if (udi == NULL) {
>> -        fprintf(stderr, "%s: libhal_get_all_devices failed\n", __FUNCTION__);
>> +        VIR_ERROR0("libhal_get_all_devices failed");
>
> ACK, although this may need modification depending on the answer to my
> question on 01/30 on why logging messages don't need translation.
>

The translation issue will be addressed separately.

Thanks, pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]