[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Explicitly set virStoragePoolTypeInfo FS and NETFS defaults



On Sun, Apr 18, 2010 at 10:30:18PM +0200, Matthias Bolte wrote:
> No semantic change, the now explicitly set default are all zero and
> that's what GCC sets unspecified struct members to.
> ---
>  src/conf/storage_conf.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
> index 620744f..6467c73 100644
> --- a/src/conf/storage_conf.c
> +++ b/src/conf/storage_conf.c
> @@ -151,6 +151,7 @@ static virStoragePoolTypeInfo poolTypeInfo[] = {
>      { .poolType = VIR_STORAGE_POOL_FS,
>        .poolOptions = {
>              .flags = (VIR_STORAGE_POOL_SOURCE_DEVICE),
> +            .defaultFormat = VIR_STORAGE_POOL_FS_AUTO,
>              .formatFromString = virStoragePoolFormatFileSystemTypeFromString,
>              .formatToString = virStoragePoolFormatFileSystemTypeToString,
>          },
> @@ -164,7 +165,7 @@ static virStoragePoolTypeInfo poolTypeInfo[] = {
>        .poolOptions = {
>              .flags = (VIR_STORAGE_POOL_SOURCE_HOST |
>                        VIR_STORAGE_POOL_SOURCE_DIR),
> -            .defaultFormat = VIR_STORAGE_POOL_FS_AUTO,
> +            .defaultFormat = VIR_STORAGE_POOL_NETFS_AUTO,
>              .formatFromString = virStoragePoolFormatFileSystemNetTypeFromString,
>              .formatToString = virStoragePoolFormatFileSystemNetTypeToString,
>          },
> -- 
> 1.6.3.3
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

ACK.  Good change.

Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]