[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/7] Deal with CPU models in []



On 04/20/2010 06:41 AM, Jiri Denemark wrote:
> Qemu committed a patch which list some CPU names in [] when asked for
> supported CPUs (qemu -cpu ?). Yet, it needs such CPUs to be passed
> without those square braces. When probing for supported CPU models, we
> can just strip the square braces and pretend we have never seen them.
> ---
>  src/qemu/qemu_conf.c |   17 +++++++++++++----
>  1 files changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 0cbedf2..63f264e 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -628,7 +628,9 @@ typedef int
>                         const char ***retcpus);
>  
>  /* Format:
> - * <arch> <model>
> + *      <arch> <model>
> + * qemu-0.13 encloses some model names in []:
> + *      <arch> [<model>]

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]