[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/7] CPU selection fixes and tests



On 04/20/2010 07:36 AM, Jiri Denemark wrote:
>> In this second version of the patchset, patches were reordered and a
>> comment for format expected by qemudParseX86Models() was modified as
>> suggested by Eric. In addition to these changes, qemu tests were fixed
>> to pass on RHEL.
>>
>> Jirka
>>
>> Jiri Denemark (7):
>>   Deal with CPU models in []
>>   Move MIN macro to util.h so that others can use it
>>   Support removing features when converting data to CPU
>>   Use configured CPU model if possible
>>   Fake host CPU for qemu tests
>>   Support for faking emulator in qemuxml2argv tests
>>   Tests for CPU selection in qemu driver
> 
> Argh, the tests cannot pass if libvirt is not already installed. So maybe it's
> better to move the tests to TCK after all...

Can we run against an uninstalled libvirt?  And if so, are we restricted
to the test:///... connection?  I'm thinking you are right that the TCK
may be the better fit here.  But while we decide how to handle
test-related commits, I see nothing blocking the non-test patches from
being pushed now.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]