[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/7] Fake host CPU for qemu tests



On 04/20/2010 06:42 AM, Jiri Denemark wrote:
> ---
>  tests/testutilsqemu.c |   30 +++++++++++++++++++++++++++++-
>  1 files changed, 29 insertions(+), 1 deletions(-)
> 
> -    if ((machines = testQemuAllocMachines(&nmachines)) == NULL)
> +    if ((caps->host.cpu = virCPUDefCopy(&host_cpu)) == NULL ||
> +        (machines = testQemuAllocMachines(&nmachines)) == NULL)
>          goto cleanup;

ACK - I think this can go in now, even if we decide to not do patches 6
or 7 at this time (in other words, even if we don't use this patch yet,
it is better to put it in now while we are thinking about it, in case we
come up with another use case in the future that would benefit from it).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]