[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Mark in_open parameter of remoteAuthenticate as unused when it's unused



On 04/20/2010 12:56 PM, Matthias Bolte wrote:
> Otherwise compiling with -Werror will fail.
> ---
> 
>  
>  static int
> -remoteAuthenticate (virConnectPtr conn, struct private_data *priv, int in_open,
> +remoteAuthenticate (virConnectPtr conn, struct private_data *priv, int in_open
> +#if !HAVE_SASL && !HAVE_POLKIT
> +                    ATTRIBUTE_UNUSED
> +#endif
> +                    ,
>                      virConnectAuthPtr auth
>  #if !HAVE_SASL && !HAVE_POLKIT
>                      ATTRIBUTE_UNUSED

I'd rather use mine instead as it occupies fewer lines and fewer
#ifdefs.  Paolo Bonzini confirmed off-list that gcc treats
ATTRIBUTE_UNUSED as _maybe_ unused, not _must be_ unused.
https://www.redhat.com/archives/libvir-list/2010-April/msg00836.html

So I rebased mine on top of yours and pushed it.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]