[libvirt] [PATCH] esx: Fix virtualHW.version generation
Matthias Bolte
matthias.bolte at googlemail.com
Tue Apr 20 22:43:34 UTC 2010
2010/4/20 Eric Blake <eblake at redhat.com>:
> On 04/18/2010 02:32 PM, Matthias Bolte wrote:
>> The supported virtualHW.version doesn't depend on the API version,
>> but on the product version.
>> ---
>> @@ -774,42 +774,41 @@ esxVMX_ParseConfig(esxVI_Context *ctx, const char *vmx,
>> goto failure;
>> }
>>
>> - switch (apiVersion) {
>> - case esxVI_APIVersion_25:
>> + /*
>> + * virtualHW.version compatibility matrix:
>> + *
>> + * 4 7 API
>> + * ESX 3.5 + 2.5
>> + * ESX 4.0 + + 4.0
>> + * GSX 2.0 + + 2.5
>> + */
>> + switch (productVersion) {
>> + case esxVI_ProductVersion_ESX35:
>> if (virtualHW_version != 4) {
>> ESX_ERROR(VIR_ERR_INTERNAL_ERROR,
>> - _("Expecting VMX entry 'virtualHW.version' to be 4 for "
>> - "VI API version 2.5 but found %lld"),
>> + _("Expecting VMX entry 'virtualHW.version' to be 4 "
>> + "but found %lld"),
>> virtualHW_version);
>> goto failure;
>
> ACK.
>
Thanks, pushed.
Matthias
More information about the libvir-list
mailing list