[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Support for qemu aio drive option



On 04/21/2010 08:28 AM, Matthias Dahl wrote:
> Revised patch against libvirt 0.7.6 to support qemu's aio option.

It's hard to tell from your comments whether you built the patch against
the latest git (0.8.0+).

> +++ b/docs/formatdomain.html.in
> @@ -478,7 +478,9 @@
>          attribute is the primary backend driver name, while the optional <code>type</code>
>          attribute provides the sub-type. The optional <code>cache</code> attribute
>          controls the cache mechanism, possible values are "default", "none",
> -        "writethrough" and "writeback". <span class="since">Since 0.1.8</span>
> +        "writethrough" and "writeback". Specific to KVM guests is the optional <code>aio</code>
> +        attribute which controls what storage api is used for io operations, its possible
> +        values are "threads" and "native". <span class="since">Since 0.1.8; "aio" attribute since 0.7.7</span>

Which means you would want to s/0.7.7/0.8.1/.

>    </define>
> +  <define name="driverAIO">
> +    <attribute name="aio">
> +      <choice>
> +        <value>threads</value>
> +        <value>native</value>
> +      </choice>
> +    </attribute>
> +  </define>
>    <define name="controller">
>      <element name="controller">
>        <optional>
...
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 766993c..8bee7b8 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -120,6 +120,11 @@ VIR_ENUM_IMPL(virDomainDiskCache, VIR_DOMAIN_DISK_CACHE_LAST,
>                "writethrough",
>                "writeback")
>  
> +VIR_ENUM_IMPL(virDomainDiskAIO, VIR_DOMAIN_DISK_AIO_LAST,
> +              "default",
> +              "native",
> +              "threads")

Why the use of "default" in the enum, but not in the XML?  Is it a third
possibility, or is it an alias for 'threads', in which case 'threads'
should be listed first?

But you are getting closer :)

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]